Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prevent Running Commands that Target Windows When the Host OS is not Windows #1010

Closed
rmartin16 opened this issue Dec 16, 2022 · 1 comment · Fixed by #1066
Closed

Prevent Running Commands that Target Windows When the Host OS is not Windows #1010

rmartin16 opened this issue Dec 16, 2022 · 1 comment · Fixed by #1066
Labels
bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start! windows The issue relates to Microsoft Windows support.

Comments

@rmartin16
Copy link
Member

Describe the bug

Running Briefcase commands for the Windows platform only works when the host OS is Windows. However, Briefcase does not inform the user of this and instead attempts to perform the Command resulting in confusing errors.

Example:

Steps to reproduce

Run briefcase build windows on macOS or Linux.

Expected behavior

Emit a simple warning informing users.

Screenshots

No response

Environment

  • Operating System: pop os 22.04
  • Python version: 3.10.8
  • Software versions:
    • Briefcase: 0.3.12.dev251+g6d29ece1

Logs

No response

Additional context

This behavior changed in v0.3.9. Previously, these Commands would have aborted when WiX was verified. But WiX is only verified now for the Package Command.
@rmartin16 rmartin16 added bug A crash or error in behavior. windows The issue relates to Microsoft Windows support. labels Dec 16, 2022
@rmartin16 rmartin16 changed the title Prevent Running Windows Commands When Not on Windows Prevent Running Commands that Target Windows When the Host OS is not Windows Dec 16, 2022
@freakboy3742 freakboy3742 mentioned this issue Dec 17, 2022
Closed
@freakboy3742 freakboy3742 added the good first issue Is this your first time contributing? This could be a good place to start! label Dec 17, 2022
@freakboy3742
Copy link
Member

Definitely an oversight. We've got analogous platform checks on the Linux backends; adding a comparable check to Windows backends definitely makes sense.

@rmartin16 rmartin16 mentioned this issue Jan 28, 2023
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start! windows The issue relates to Microsoft Windows support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generalize enforcement of host operating system requirements rmartin16/briefcase
2 participants
@freakboy3742 @rmartin16