Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set minimum version of python supported to run coverage #1241

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Set minimum version of python supported to run coverage #1241

merged 4 commits into from
Apr 26, 2023

Conversation

paxnovem
Copy link
Contributor

@paxnovem paxnovem commented Apr 26, 2023 •
edited
Loading

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@paxnovem
Set minimum version of python supported to run coverage
0c83e65 
Signed-off-by: Brian Grohe <grohe43@email.com>
@rmartin16
Copy link
Member

rmartin16 commented Apr 26, 2023 •
edited
Loading

a shiny penny could be in order ;)

paxnovem added 2 commits April 25, 2023 18:33
@paxnovem
Added town crier and trim white space
e0b9983 
Signed-off-by: Brian Grohe <grohe43@gmail.com>
@paxnovem
Update 1241.misc.rst
3c35c3e 
Signed-off-by: Brian Grohe<grohe@gmail.com>
@paxnovem paxnovem marked this pull request as ready for review April 26, 2023 00:37
@paxnovem
Switch to using a context manager
131721c 
Signed-off-by: Brian Grohe <grohe43@gmail.com>
freakboy3742
freakboy3742 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for digging into this!

@freakboy3742 freakboy3742 merged commit 1d8fbd8 into beeware:main Apr 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paxnovem @rmartin16 @freakboy3742