Move command-line args out of dev-mode Python invocation #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeamland
force-pushed
the
jeamland/briefcase-dev-argv-hilarity
branch
2 times, most recently
from
dfbbc23 to
7c1c45a
Compare
freakboy3742
requested changes
Aug 21, 2023
On macOS CoreFoundation/NSApplication will do its own independent parsing of argc/argv. This means that whatever we pass to the Python interpreter on start-up will also be visible to NSApplication which will interpret things like `-u` (used to make I/O unbuffered in CPython) as `-u [URL]` (a request to open a document by URL). This is, rather patently, Not Good. To avoid this causing unwanted hilarity, we use environment variables to configure the Python interpreter rather than command-line options.
jeamland
force-pushed
the
jeamland/briefcase-dev-argv-hilarity
branch
from
7c1c45a to
c3cc4ee
Compare
rmartin16
reviewed
Aug 21, 2023
Comment on lines
+31
to
+35
| # Equivalent of passing "-X dev" | ||
| "PYTHONMALLOC": "debug", | ||
| "PYTHONASYNCIODEBUG": "1", | ||
| "PYTHONFAULTHANDLER": "1", | ||
| "PYTHONWARNINGS": "default", |
There was a problem hiding this comment.
Curious....was there a reason that PYTHONDEVMODE=1 wasn't used instead?
Setting just PYTHONDEVMODE seems more likely to be forward-compatible with enabling this mode.
There was a problem hiding this comment.
...we didn't realise the setting existed :-)
It's obvious now that I'm looking at the docs; no objection replacing these 4 settings with the single PYTHONDEVMODE=1
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason NSApplication/CoreFoundation gets very confused if we pass certain command-line arguments to the outer Python interpreter when running in dev mode.
This patch removes all command-line arguments from the invocation, using environment variables to achieve the equivalent outcomes. The remaining argument, the actual code to start the application, appears to not cause problems.