Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fail CI if a default encoding is used #1454

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Sep 15, 2023

Changes

  • When CI runs, require an explicit encoding anywhere one is needed

Notes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the warn-default-encoding branch from 74ebe21 to 480a296 Compare September 15, 2023 17:19
@rmartin16
Copy link
Member Author

rmartin16 commented Sep 22, 2023

more weirdness with cookiecutter releases....2.3.1 is on PyPI but the GitHub release was deleted...(i know it existed at one point because GitHub sent me the release notification...)

GitHub release was restored.

PyPI
GitHub release

@rmartin16 rmartin16 marked this pull request as ready for review September 22, 2023 13:55
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Worth noting that this won't do anything on Py3.8 or 3.9, as the warn_default_encoding flag wasn't added until 3.10; but it's a no-op, so it doesn't hurt, and we really only need one version to fail.

@freakboy3742 freakboy3742 merged commit 685080d into beeware:main Sep 25, 2023
@rmartin16 rmartin16 deleted the warn-default-encoding branch October 2, 2023 17:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants