Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exclude logging output from emulator list #1697

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Mar 14, 2024

Changes

  • Recently, emulator -list-avds started including logging output in the list of AVDs...so, it's ignored now
>>> Running Command:
>>>     /opt/sdks/Android/sdk/emulator/emulator -list-avds
>>> Working Directory:
>>>     /home/russell/tmp/beeware/helloworld
>>> Command Output:
>>>     INFO    | Storing crashdata in: /tmp/android-russell/emu-crash-34.1.19.db, detection is enabled for process: 2413840
>>>     Pixel_3a_API_31
>>>     Pixel_5_API_31
>>>     Pixel_6a_API_31
>>>     Pixel_7a_API_34
>>>     Pixel_8_Pro_API_31
>>>     beePhone
>>> Return code: 0

Select device:

  1) Unknown device (offline) (emulator-5554)
  2) @INFO    | Storing crashdata in: /tmp/android-russell/emu-crash-34.1.19.db, detection is enabled for process: 2413840 (emulator)
  3) @Pixel_3a_API_31 (emulator)
  4) @Pixel_5_API_31 (emulator)
  5) @Pixel_6a_API_31 (emulator)
  6) @Pixel_7a_API_34 (emulator)
  7) @Pixel_8_Pro_API_31 (emulator)
  8) @beePhone (emulator)
  9) Create a new Android emulator

>

Other mayhem caused by this logging.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review March 14, 2024 18:10
@rmartin16 rmartin16 requested a review from freakboy3742 March 14, 2024 18:10
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fairly straightforward. I've got a mild concern that the INFO | prefix might not match with time, but we can cross that bridge once we have data indicating it's a problem - it's going to be near impossible to work out how it might shift in future releases.

@freakboy3742 freakboy3742 merged commit d4e2a43 into beeware:main Mar 14, 2024
51 checks passed
@rmartin16 rmartin16 deleted the emulator-avd branch March 15, 2024 06:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants