Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace add_background_task() in Toga automation bootstrap #1977

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Aug 29, 2024

Changes

  • Fix CI warnings for deprecated add_background_task()
2024-08-29T17:16:25.7757238Z �[2m[verifyapp]�[0m Starting app...
2024-08-29T17:16:25.7797688Z ===========================================================================
2024-08-29T17:16:26.3294634Z 
2024-08-29T17:16:26.3310775Z (verifyapp:3766): dbind-WARNING **: 17:16:26.328: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
2024-08-29T17:16:26.4161697Z /home/runner/work/briefcase-template/briefcase-template/apps/verifyapp/build/verifyapp/ubuntu/jammy/verifyapp-0.0.1/usr/lib/verifyapp/app/verifyapp/app.py:26: DeprecationWarning: App.add_background_task is deprecated. Use asyncio.create_task(), or set an App.on_running() handler
2024-08-29T17:16:26.4177389Z   self.add_background_task(self.exit_soon)
2024-08-29T17:16:28.4233150Z >>> successfully started...exiting <<<

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review August 29, 2024 18:05
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 8938880 into beeware:main Aug 29, 2024
52 checks passed
@rmartin16 rmartin16 deleted the automation branch August 29, 2024 22:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants