Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Include python3 executable in code signing #514

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Include python3 executable in code signing #514

merged 2 commits into from
Oct 24, 2020

Conversation

samschott
Copy link
Member

This fixes #513 by explicitly signing the Python executable in the Resources folder.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - not sure how I missed that one in my original pass.

@freakboy3742 freakboy3742 merged commit 8e36744 into beeware:master Oct 24, 2020
@samschott samschott deleted the patch-2 branch October 24, 2020 08:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code signing does not sign Python executable on macOS
2 participants
@samschott @freakboy3742