Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add no-run option to dev command #522

Merged
merged 4 commits into from
Nov 21, 2020
Merged

Add no-run option to dev command #522

merged 4 commits into from
Nov 21, 2020

Conversation

saroad2
Copy link
Member

@saroad2 saroad2 commented Nov 1, 2020

One can now install dev-mode dependencies without actually running the app.
This is good for testing and CI/CD purposes.

This is a retry of #506

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@saroad2 saroad2 requested a review from freakboy3742 November 1, 2020 07:34
freakboy3742
freakboy3742 requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a couple of minor suggestions, mostly aiding readability.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #522 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/briefcase/commands/dev.py 86.36% <100.00%> (+0.87%) ⬆️

freakboy3742
freakboy3742 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 A solid addition - thanks!

@freakboy3742 freakboy3742 merged commit 83c1fd5 into beeware:master Nov 21, 2020
@saroad2 saroad2 deleted the dev_command_no_run branch November 28, 2020 09:44
@jgirardet jgirardet mentioned this pull request Feb 16, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saroad2 @freakboy3742