Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix GC leak in js_proxy_get() #302

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented May 16, 2024

Simplified test case to reproduce:

function a() {
    return {};
}
var d = new Date();
var o1 = new Proxy(d, {get: 0});
var o2 = new Proxy(d, o1);
var o = new Proxy(o2, {get: a})

o.a

Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chqrlie can we get this landed?

@chqrlie chqrlie merged commit b3715f7 into bellard:master Jul 14, 2024
13 checks passed
nickva added a commit to apache/couchdb that referenced this pull request Jul 18, 2024
Update from latest master. Bring in these two fixes:
 * bellard/quickjs#302
 * bellard/quickjs#313
nickva added a commit to apache/couchdb that referenced this pull request Jul 18, 2024
Update from latest master. Bring in these two fixes:
 * bellard/quickjs#302
 * bellard/quickjs#313
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants