Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix JS_HasException() when null is thrown #313

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kasperisager
Copy link
Contributor

Closes #312

Copy link
Collaborator

@chqrlie chqrlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using JS_UNINITIALIZED is a clever solution to allow for any valid value to be thrown.

@saghul
Copy link
Contributor

saghul commented Jul 16, 2024

@chqrlie Shall this be merged?

@chqrlie chqrlie merged commit 5417ab0 into bellard:master Jul 17, 2024
13 checks passed
@kasperisager kasperisager deleted the has-exception branch July 17, 2024 12:04
nickva added a commit to apache/couchdb that referenced this pull request Jul 18, 2024
Update from latest master. Bring in these two fixes:
 * bellard/quickjs#302
 * bellard/quickjs#313
nickva added a commit to apache/couchdb that referenced this pull request Jul 18, 2024
Update from latest master. Bring in these two fixes:
 * bellard/quickjs#302
 * bellard/quickjs#313
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants