-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
numpy has teriminated the get_info
method
#691
Comments
Upvote. Facing same issue - now we have to manage numpy dependency explicitly. Would be great if this could be addressed. |
I think we should probably remove this block of code. We're trying to detect a potential performance problem (having BLAS configured to use a threadpool causes severe perf isues since we are also internally multi-threading which leads to thrashing- so we want to make sure that BLAS is configured to just use one thread, and we're using this method to try to figure out which BLAS library is being used by numpy). Instead I think we should use https://github.com/joblib/threadpoolctl here - which both lets us get the threadpool status for the BLAS libraries, as well as programmatically set it. This means rather than just detecting the perf issue, we can configure BLAS appropriately to not have the issue in the first place. |
Fix is in the 0.7.2 release : https://github.com/benfred/implicit/releases/tag/v0.7.2 |
In the latest versions of
numpy>1.24.0
,np.__config__.get_info
method has been terminated, which is causing the follwoing error when running theALS
:AttributeError: module 'numpy.__config__' has no attribute 'get_info'
.The functionality is used to detect
OpenBLAS
andIntel MKL BLAS
.Simple fix is to use the function
get_info
which numpy has deprecated.The text was updated successfully, but these errors were encountered: