Merge pull request #35 from SimeonC/fix-change-maxRows

benhowell · web-flow · commit ea594990a350 · 2017-07-20T12:35:08.000+10:00
fix(Gallery): Should update thumbnails when maxRows changes

This fix checks new props for change in maxRows.
diff --git a/src/Gallery.js b/src/Gallery.js
@@ -31,7 +31,7 @@ class Gallery extends Component {
     }
 
     componentWillReceiveProps (np) {
-        if(this.state.images != np.images){
+        if(this.state.images != np.images || this.props.maxRows != np.maxRows){
             this.setState({
                 images: np.images,
                 thumbnails: this.renderThumbs(this._gallery.clientWidth,

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class Gallery extends Component {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`componentWillReceiveProps (np) {`
`34`		`- if(this.state.images != np.images){`
	`34`	`+ if(this.state.images != np.images \|\| this.props.maxRows != np.maxRows){`
`35`	`35`	`this.setState({`
`36`	`36`	`images: np.images,`
`37`	`37`	`thumbnails: this.renderThumbs(this._gallery.clientWidth,`