Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typings do not include showUnchanged and hideUnchanged for html formatter #234

Closed
ian-craig opened this issue Jun 27, 2018 · 2 comments · Fixed by #236
Closed

Typings do not include showUnchanged and hideUnchanged for html formatter #234

ian-craig opened this issue Jun 27, 2018 · 2 comments · Fixed by #236

Comments

@ian-craig
Copy link
Contributor

Typings (index.d.ts) for the html formatter only include the format method.

export interface Formatter {
  format(delta: Delta, original: any): string;
}

export const formatters: {
  annotated: Formatter;
  console: Formatter;
  html: Formatter;
};

showUnchanged and hideUnchanged should also be present.

Given these are only on the HTML formatter we'll probably need to add a separate type for this.

@ian-craig ian-craig changed the title Typings do not include showUnchanged and hideUnchanged for html formatter Typings do not include showUnchanged and hideUnchanged for html formatter Jun 27, 2018
@benjamine
Copy link
Owner

benjamine commented Jun 27, 2018

thanks 👍 , I'm not familiar with TS annotations myself, I could give it a try but a PR would be very welcome for this.

@ian-craig
Copy link
Contributor Author

@benjamine Any update on when this will be merged and a new version published? I'd love to be able to remove the workarounds in my projects for this and another open PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants