Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mistake in libsv/libsv/coders/encoder_8b10b.sv #151

Closed
jvnknvlgl opened this issue May 22, 2024 · 2 comments · Fixed by #153
Closed

Mistake in libsv/libsv/coders/encoder_8b10b.sv #151

jvnknvlgl opened this issue May 22, 2024 · 2 comments · Fixed by #153
Assignees
@bensampson5
Labels
bug Something isn't working

Comments

@jvnknvlgl
Copy link

jvnknvlgl commented May 22, 2024 •
edited
Loading

Hello!

I am working on implementing 8b/10b encoding in a different project, and I stumbled upon the lookup table for encoding in this project. After writing my tests, I think I have found a mistake in your code in encoder_8b10b.sv: for all code groups D28.X, the last 6 bits are 001110 while they should actually be 011100 according to the table in IEEE 802.3. Could this be possible?
@bensampson5 bensampson5 self-assigned this May 26, 2024
@github-actions GitHub Actions
Copy link

Branch issue-151-Mistake_in_libsv/libsv/coders/encoder_8b10b_sv created!

@bensampson5 bensampson5 mentioned this issue May 26, 2024
Merged
@bensampson5 bensampson5 added the bug Something isn't working label May 26, 2024
@bensampson5
Copy link
Owner

Nice find! It is a bug and I fixed it on main. Thanks for leaving feedback

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bensampson5 bensampson5

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 8b10b encoder issue bensampson5/libsv
2 participants
@jvnknvlgl @bensampson5