[dashboard] Confusion between preserve_job_records and data on dashboard

[francois]

Our config/application.rb contains the following line:

config.good_job.preserve_job_records = false

The job itself is declared thusly:

class DetectBundleExtensionJob < ApplicationJob
  # @TODO: While we are migrating from Sidekiq, declare individual queue adapters where needed
  self.queue_adapter = :good_job

  retry_on StandardError, attempts: 0

  def perform(inspection_id)
    # implementation
  end
end

How come the dashboard shows completed jobs? I mean the navbar/page header as well as the list of jobs at the bottom.

In the end, we want to preserve jobs for a bit, but we had an issue (unrelated to GoodJob) and we haven't reset our config to preserve records yet.

[bensheldon]

Weird! I'm not sure why that would be. preserve_job_records is checked when the job execution finishes:

good_job/app/models/good_job/job.rb

Lines 700 to 708 in b557525

	preserve_unhandled = result.unhandled_error && (GoodJob.retry_on_unhandled_error || GoodJob.preserve_job_records == :on_unhandled_error)
	if finished_at.blank? || GoodJob.preserve_job_records == true || reenqueued || preserve_unhandled || cron_key.present?
	transaction do
	execution.save!
	save!
	end
	else
	destroy!
	end