Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Guard against colinear seed points #8

Open
debk1 opened this issue Feb 14, 2023 · 1 comment
Open

Guard against colinear seed points #8

debk1 opened this issue Feb 14, 2023 · 1 comment

Comments

@debk1
Copy link

debk1 commented Feb 14, 2023

I've found this code very useful -- thank you. Surface reconstruction is out of my area of expertise so this comment might be invalid... I have found the need to guard against colinear points in findSeedTriangle. Otherwise it can return a seed triangle with normal()=nan

@bernhardmgruber
Copy link
Owner

Hi! Thank you for reaching out! I am glad you found it useful!

This implementation is intentionally kept simple so I am sure there are lots of quality bugs like the one you described. If I find some time, I can implement a quick fix, like enforcing a minimum for all angles in the seed triangle, or a minimum area, etc. Feel free to also propose a PR!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants