Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Match commits to PRs by using the extracted PR number #1851

Open
alice-i-cecile opened this issue Nov 26, 2024 · 1 comment
Open

Match commits to PRs by using the extracted PR number #1851

alice-i-cecile opened this issue Nov 26, 2024 · 1 comment
Labels
A-Migration Guides A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code

Comments

@alice-i-cecile
Copy link
Member

As seen in #1518, matching PRs by names is unreliable due to both time windows and renames. The fundamental strategy here is dumb though: we should be able to extract the PR number / link responsible from the commit message and then look it up directly. No inexact matching or expensive "grab all PRs" required.

@alice-i-cecile alice-i-cecile added A-Migration Guides A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code labels Nov 26, 2024
@mockersf
Copy link
Member

it's what I do in the script to cherry pick commits for a release candidate:

if git log --format=oneline | grep " (#$number)$" > /dev/null; then

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-Migration Guides A-Release-Notes C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code
Projects
None yet
Development

No branches or pull requests

2 participants