Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rework CONTRIBUTING:BEPs section for schema-driven approach #24

Open
yarikoptic opened this issue Oct 19, 2023 · 2 comments
Open

Rework CONTRIBUTING:BEPs section for schema-driven approach #24

yarikoptic opened this issue Oct 19, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@yarikoptic
Copy link
Contributor

ATM it still talks about changing regexes etc. It should be

  • prepare branch/PR against bids-specification with changes for the BEP
  • follow instructions here and/or there which boil down to
    • convert adjusted schema: cd bids-specification; bst -v export --output src/schema.json (fix if/how needed)
    • use it to validate sample data <path to bids-validator install>/bids-validator-deno -s src/schema.json <path to dataset>
@yarikoptic
Copy link
Contributor Author

FWIW setting up something like that in https://github.com/bids-standard/bids-specification/pull/1775/files#diff-340dd8fa4a5cba6b30520d676d1831fd82628971874ea46396e3ace6c6ef0f03 but with complication that I am also doing conversion of example datasets to BIDS 2.0.
Besides that step I think we might benefit from similar action generally be available there and thus testing across all example datasets. ATM bst unittests only test some selected few with internal validator, not JS one.

@effigies effigies transferred this issue from bids-standard/legacy-validator Nov 4, 2024
@effigies effigies added the documentation Improvements or additions to documentation label Nov 7, 2024
@effigies
Copy link
Contributor

effigies commented Nov 7, 2024

I have removed the legacy bits, have not yet added schema bits.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants