Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI, credo, formatting, etc #8

Open
harlantwood opened this issue Mar 14, 2018 · 1 comment
Open

CI, credo, formatting, etc #8

harlantwood opened this issue Mar 14, 2018 · 1 comment

Comments

@harlantwood
Copy link

Hi, I've been working with your (great) project as I'm learning elixir. I've made some updates that may be of interest... others maybe not. Take a look and let me know if you'd like me to PR some of this back to you.

All of the formatting changes are tool generated, from mix format and elm-format. There are also some fixes suggested by credo.

Please ignore the crazy commit history, if I PR I'll make well formed commits of course.

tutorial/part-6...harlantwood:dev
@harlantwood
Copy link
Author

It's also measuring test coverage btw: https://coveralls.io/github/harlantwood/phoenix-and-elm?branch=dev

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harlantwood