You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using jsdom, the host's architecture is reported. On the mac:
Mozilla/5.0 (darwin) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/11.12.0
On Linux (CI):
Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/11.12.0
isMac does not comprehend darwin as being a Mac and, therefore, does not report it as isDesktop. When running on CircleCI with Linux, this will report isLinux: true, triggering isDesktop: true.
I propose that isMac also check for darwin. If you're ok with this, I'll happily open a PR :)
The text was updated successfully, but these errors were encountered:
When using jsdom, the host's architecture is reported. On the mac:
On Linux (CI):
isMac
does not comprehenddarwin
as being a Mac and, therefore, does not report it asisDesktop
. When running on CircleCI with Linux, this will reportisLinux: true
, triggeringisDesktop: true
.I propose that
isMac
also check fordarwin
. If you're ok with this, I'll happily open a PR :)The text was updated successfully, but these errors were encountered: