Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inconsistent results for isDesktop with jsdom #109

Open
justinanastos opened this issue Mar 1, 2019 · 0 comments
Open

Inconsistent results for isDesktop with jsdom #109

justinanastos opened this issue Mar 1, 2019 · 0 comments

Comments

@justinanastos
Copy link

When using jsdom, the host's architecture is reported. On the mac:

Mozilla/5.0 (darwin) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/11.12.0

On Linux (CI):

Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/11.12.0

isMac does not comprehend darwin as being a Mac and, therefore, does not report it as isDesktop. When running on CircleCI with Linux, this will report isLinux: true, triggering isDesktop: true.


I propose that isMac also check for darwin. If you're ok with this, I'll happily open a PR :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@justinanastos and others