Skip to content

Commit

Permalink
refactor : AttendanceNumberRepository를 제거하고 AttendanceService에 OpenLe…
Browse files Browse the repository at this point in the history
…ctureRepository 적용 (#62)
  • Loading branch information
binary-ho committed Aug 20, 2023
1 parent 88abf4a commit c19a75d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 58 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@


import gdsc.binaryho.imhere.core.attendance.Attendance;
import gdsc.binaryho.imhere.core.attendance.application.port.AttendanceNumberRepository;
import gdsc.binaryho.imhere.core.attendance.exception.AttendanceNumberIncorrectException;
import gdsc.binaryho.imhere.core.attendance.exception.AttendanceTimeExceededException;
import gdsc.binaryho.imhere.core.attendance.infrastructure.AttendanceRepository;
Expand All @@ -14,6 +13,7 @@
import gdsc.binaryho.imhere.core.enrollment.infrastructure.EnrollmentInfoRepository;
import gdsc.binaryho.imhere.core.lecture.Lecture;
import gdsc.binaryho.imhere.core.lecture.LectureState;
import gdsc.binaryho.imhere.core.lecture.application.port.OpenLectureRepository;
import gdsc.binaryho.imhere.core.lecture.exception.LectureNotFoundException;
import gdsc.binaryho.imhere.core.lecture.exception.LectureNotOpenException;
import gdsc.binaryho.imhere.core.lecture.infrastructure.LectureRepository;
Expand All @@ -39,7 +39,7 @@ public class AttendanceService {
private final AttendanceRepository attendanceRepository;
private final EnrollmentInfoRepository enrollmentRepository;
private final LectureRepository lectureRepository;
private final AttendanceNumberRepository attendanceNumberRepository;
private final OpenLectureRepository openLectureRepository;

@Transactional
public void takeAttendance(AttendanceRequest attendanceRequest, Long lectureId) {
Expand Down Expand Up @@ -79,7 +79,7 @@ private void validateLectureOpen(EnrollmentInfo enrollmentInfo) {

private void validateAttendanceNumber(EnrollmentInfo enrollmentInfo, int attendanceNumber) {
long lectureId = enrollmentInfo.getLecture().getId();
Integer actualAttendanceNumber = attendanceNumberRepository.getByLectureId(lectureId);
Integer actualAttendanceNumber = openLectureRepository.findAttendanceNumber(lectureId);

validateAttendanceNumberNotTimeOut(actualAttendanceNumber);
validateAttendanceNumberCorrect(actualAttendanceNumber, attendanceNumber);
Expand Down Expand Up @@ -146,9 +146,4 @@ private LocalDateTime getDayLocalDateTime(Long milliseconds) {
.ofInstant(Instant.ofEpochMilli(milliseconds), ZoneId.of("Asia/Seoul"))
.withHour(0).withMinute(0).withSecond(0);
}

@Transactional
public void saveAttendanceNumber(Long lectureId, int attendanceNumber) {
attendanceNumberRepository.saveWithLectureIdAsKey(lectureId, attendanceNumber);
}
}

This file was deleted.

This file was deleted.

0 comments on commit c19a75d

Please # to comment.