Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search function #11

Closed
RosieCampbell opened this issue Jul 24, 2020 · 10 comments
Closed

Search function #11

RosieCampbell opened this issue Jul 24, 2020 · 10 comments
Labels
feature New feature or request wontfix This will not be worked on

Comments

@RosieCampbell
Copy link

I'd like to be able to bring up a search bar to search across all content on the site.

@binyamin binyamin added the feature New feature or request label Jul 24, 2020
@binyamin
Copy link
Owner

binyamin commented Jul 26, 2020

Great idea.

Here are some relevant articles/solutions, for anyone tackling this issue:

@itsthecheat
Copy link

Hello,
If this is still available I'd be happy to work on it!

@binyamin
Copy link
Owner

binyamin commented Oct 5, 2020

@itsthecheat Sure! Lmk if you need anything.

@binyamin
Copy link
Owner

@itsthecheat Are you still working on this? Asking because #4 will be affected by this feature.

@binyamin
Copy link
Owner

@tannerdolby @RosieCampbell How many notes should we expect to be searching through?

@tannerdolby
Copy link

I was asking myself this question last night. Which made me think: How many hashtags should the project support? Currently the tags in #33 are hardcoded to look for (#art, #easter, #food) to produce lists of related notes.

Right now the project has 4 notes.

  • art.md
  • food.md
  • bar.md
  • Easter egg.md

I think we could expect to search for around 10 notes or < 20. Where this ceiling of notes to be searched can be updated as the project grows, allowing the search to index more notes.

As the number of notes increases, the potential for new hashtags arises. I think the number of hashtags could be set to a default 3 or something like? Allowing for more hashtags to be added via the tags.liquid template.

@binyamin
Copy link
Owner

Where this ceiling of notes to be searched can be updated as the project grows

@tannerdolby My intent was more that the search will get slower with more documents. If possible, I don't want to manually limit the number of items searched.

I think the number of hashtags could be set to a default 3 or something like?

I don't think we should limit the number of possible hashtags. I don't want to make users comb through their notes, looking for which tags they use.

@tannerdolby
Copy link

How many notes should we expect to be searching through?

@binyamin I agree, the search will definitely become slower with more documents. I was only giving my thoughts for an expected number of notes within /notes/ to be searching through.

I don't want to make users comb through their notes, looking for which tags they use.

Agreed, the implementation I proposed in #33 will have to be updated to dynamically create related lists rather than what I've spun up for the first prototype.

@gerwitz
Copy link

gerwitz commented Dec 30, 2020

FWIW, I implemented search on my personal Eleventy site with lunr (the "father" of Elasticlunr) and it works brilliantly and performs fairly well with nearly 1,000 pages.

@binyamin binyamin added the help wanted Extra attention is needed label Mar 11, 2021
@binyamin
Copy link
Owner

I'm considering this out-of-scope. See #71 (comment)

@binyamin binyamin closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2022
@binyamin binyamin added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Jun 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants