-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Search function #11
Comments
Great idea. Here are some relevant articles/solutions, for anyone tackling this issue:
|
Hello, |
@itsthecheat Sure! Lmk if you need anything. |
@itsthecheat Are you still working on this? Asking because #4 will be affected by this feature. |
@tannerdolby @RosieCampbell How many notes should we expect to be searching through? |
I was asking myself this question last night. Which made me think: How many hashtags should the project support? Currently the tags in #33 are hardcoded to look for (#art, #easter, #food) to produce lists of related notes. Right now the project has 4 notes.
I think we could expect to search for around 10 notes or < 20. Where this ceiling of notes to be searched can be updated as the project grows, allowing the search to index more notes. As the number of notes increases, the potential for new hashtags arises. I think the number of hashtags could be set to a default 3 or something like? Allowing for more hashtags to be added via the |
@tannerdolby My intent was more that the search will get slower with more documents. If possible, I don't want to manually limit the number of items searched.
I don't think we should limit the number of possible hashtags. I don't want to make users comb through their notes, looking for which tags they use. |
@binyamin I agree, the search will definitely become slower with more documents. I was only giving my thoughts for an expected number of notes within
Agreed, the implementation I proposed in #33 will have to be updated to dynamically create related lists rather than what I've spun up for the first prototype. |
FWIW, I implemented search on my personal Eleventy site with lunr (the "father" of Elasticlunr) and it works brilliantly and performs fairly well with nearly 1,000 pages. |
I'm considering this out-of-scope. See #71 (comment) |
I'd like to be able to bring up a search bar to search across all content on the site.
The text was updated successfully, but these errors were encountered: