Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Analyze doesn't work if some of the runs did not complete #26

Closed
mimischi opened this issue Jan 24, 2018 · 0 comments
Closed

Analyze doesn't work if some of the runs did not complete #26

mimischi opened this issue Jan 24, 2018 · 0 comments

Comments

@mimischi
Copy link
Contributor

Error report

Expected behavior

mdbenchmark analyze should show a performance of 0 or some other value (e.g. "simulation not finished"), if it can't find the Performance line in the output file.

Actual behavior

It exits due to this line and the user is shown the typical python stack trace, caused by the warnings.warn.

Currently version of MDBenchmark:

$ mdbenchmark --version
mdbenchmark, version 1.1.1

Proposal

We previously just showed a default value of "0" for all the performances that were not found. We most definitely should go ahead and warn the user that specific systems have not finished yet/correctly, but the current implementation only works if all the runs have finished successfully.

I noticed when GROMACS was not able to do domain decomposition on more than 1 node, so these benchmarks crashed right after starting. The benchmark with one node did work, but mdbenchmark didn't show the actual results.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant