Skip to content

build: benchmarks and examples should be disabled when external callbacks are enabled #1308

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
real-or-random opened this issue May 12, 2023 · 4 comments · May be fixed by #1325
Open

build: benchmarks and examples should be disabled when external callbacks are enabled #1308

real-or-random opened this issue May 12, 2023 · 4 comments · May be fixed by #1325
Labels
build

Comments

@real-or-random
Copy link
Contributor

see #1306
@real-or-random real-or-random changed the title buildd: benchmarks and examples should be disabled when external callbacks are enabled build: benchmarks and examples should be disabled when external callbacks are enabled May 12, 2023
@hebasto hebasto linked a pull request May 24, 2023 that will close this issue
Open
@hebasto
Copy link
Member

hebasto commented May 24, 2023

What about ctime_tests?

@real-or-random
Copy link
Contributor Author

What about ctime_tests?

Ok yes, I haven't checked. Do they build successfully if external callback are enabled? If no, then I guess we should disable the ctime_tests as well...

@hebasto
Copy link
Member

hebasto commented May 24, 2023

Do they build successfully if external callback are enabled?

No, they don't.

@real-or-random
Copy link
Contributor Author

Ok yes, then they should be also be covered in #1325

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Disable some targets when external callbacks are enabled hebasto/secp256k1
2 participants
@real-or-random @hebasto