Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Alpha3Error #495

Closed
7 of 8 tasks
reez opened this issue Apr 18, 2024 · 0 comments · Fixed by #492, #493, #494, #506 or #507
Closed
7 of 8 tasks

Remove Alpha3Error #495

reez opened this issue Apr 18, 2024 · 0 comments · Fixed by #492, #493, #494, #506 or #507
Assignees
Labels
enhancement New feature or request

Comments

@reez
Copy link
Collaborator

reez commented Apr 18, 2024

Describe the enhancement

Just creating a tracking Issue for removing the Alpha3Error, which will mean that we have implemented specific error types for everything needed in bdk-ffi

Additional context
I currently have a few open draft PR's on this so thought it was a good idea to have a tracking Issue

TODO

  • format
  • alphabetize?
  • re-order UDL & error.rs
  • tests
  • update UDL with proper section headings for some of these (for example, under keys mnemonic from_string/entropy & pathconstructor should not be under descriptor module in UDL)
  • naming of error strings (e/err/error/error_message)
  • For the “from”s should we type alias to bdkXYZError or should we be fully explicit like bdk::bitcoin::psbt::ExtractTxError?
  • For this error should we do use thiserror::Error;
@reez reez added the enhancement New feature or request label Apr 18, 2024
@reez reez self-assigned this Apr 18, 2024
@reez reez mentioned this issue Apr 18, 2024
8 tasks
@reez reez reopened this Apr 19, 2024
This was linked to pull requests Apr 20, 2024
@reez reez reopened this Apr 23, 2024
@reez reez reopened this Apr 24, 2024
@reez reez reopened this Apr 29, 2024
@reez reez linked a pull request May 1, 2024 that will close this issue
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment