fix: prevent hoisting of the undefined global variable in browser.js

[valeriangalliat]

Purpose

Because of JS hoisting var global to the top of the file, typeof global in getGlobal() will always be undefined.

This can be a problem when bundling this code and running it in an environment that doesn't have self of window defined but has global.

In practice I ran into this issue after browserifying node-fetch and running the bundle in node --experimental-fetch (just to test).

I can confirm after this fix I can browserify node-fetch and have it expose the global fetch function when run into node --experimental-fetch.

Changes

By using a different variable name like globalObject, we are able to read the "real" typeof global and get access to the global object that way.

[ahaoboy]

@valeriangalliat This global var is also need to change? or add var global = globalObject?

node-fetch/src/index.js

Line 395 in e218f8d

fetch.Promise = global.Promise;

 fetch.Promise = global.Promise;

[ahaoboy]

@LinusU @NotMoni @jimmywarting PTAL

[LinusU]

👍

[github-actions]

🎉 This PR is included in version 2.6.8 🎉

The release is available on:

• npm package (@release-2.x dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jimmywarting]

in some aftermath i think we should instead have used the globalThis instead but maybe to late now...