Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

createTx checks #757

Open
inaltoasinistra opened this issue Jan 17, 2018 · 1 comment
Open

createTx checks #757

inaltoasinistra opened this issue Jan 17, 2018 · 1 comment

Comments

@inaltoasinistra
Copy link

Hello,
I'm working on a forked version of your wallet, it'll add external inputs to the transactions. I saw that WalletService.prototype.createTx does not check if all the inputs are owned by the wallet, but there is a TODO about this:

todo: check inputs are ours and have enough value

Do you intend to add this check? If yes, will you add a way to skip the check?

Thank you

@inaltoasinistra
Copy link
Author

The inputs check is done in other parts of the code, so it is not possible create txs with heterogeneous inputs using createTx. I create the txs on the client, with problems to transactions data into the wallet

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant