Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change address cannot be restored from backup #1078

Closed
KhangHLe opened this issue Aug 13, 2014 · 4 comments · Fixed by #1123
Closed

Change address cannot be restored from backup #1078

KhangHLe opened this issue Aug 13, 2014 · 4 comments · Fixed by #1123
Assignees

Comments

@KhangHLe
Copy link

  1. Create any type of wallet
  2. Create a backup immediately
  3. Receive payments into an address
  4. Spend some (not all) of the funds so that a change address is created
  5. Delete wallet (do not backup)
  6. Restore from the backup made in step 2

Problem: The receiving address made was restored but the change address is gone and there is no way to get it back manually.

Why is this a problem: The purpose of HD Wallet was so that a single backup can restore all your funds in case of hardware failure or other issues, this can be detrimental if the majority of your funds are in change addresses.

@maraoz
Copy link
Contributor

maraoz commented Aug 15, 2014

Hey @ZIONhikari. Sorry to hear you're having problems restoring a backup. Thanks for the detailed explanation on how to reproduce the bug. I'll follow your steps and report back.

  1. I created a testnet 1-of-1 in https://copay.io/app
  2. done
  3. done, sent 0.1 btc from testnet bitcoind
  4. done, sent 0.05 btc back to bitcoind, have 0.0499 in change address
  5. done
  6. done.

wow. you're right! My balance is gone! ping @yemel (who did the address scanning algorithm at import time).
Can you look at this please?

@ZIONhikari don't worry, the change address is part of the HD wallet, so your money is not lost (in case you were using livenet). We need to fix the import algorithm to find all change addresses apparently. Thanks for letting us know!!!

@KhangHLe
Copy link
Author

Hey @maraoz, thanks for the reply, luckily I did not lose any livenet money because the wallet sync with your other copayers :)

@maraoz
Copy link
Contributor

maraoz commented Aug 16, 2014

Ah, the magic of mutlisig :)
This is a serious issue though, and we'll look into it in depth. Thanks for
reporting

On Sat, Aug 16, 2014 at 4:02 AM, ZionHikari notifications@github.com
wrote:

Hey @maraoz https://github.com/maraoz, thanks for the reply, luckily I
did not lose any livenet money because the wallet sync with your other
copayers :)

Reply to this email directly or view it on GitHub
https://github.com/bitpay/copay/issues/1078#issuecomment-52386000.

@matiu matiu added the ready label Aug 18, 2014
@matiu matiu self-assigned this Aug 18, 2014
@matiu
Copy link
Contributor

matiu commented Aug 18, 2014

on it now.

@matiu matiu mentioned this issue Aug 18, 2014
@matiu matiu added in progress and removed ready labels Aug 18, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants