Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CLI startup option to only generate keys #1011

Closed
3 of 6 tasks
abitmore opened this issue Jun 2, 2018 · 10 comments
Closed
3 of 6 tasks

Add CLI startup option to only generate keys #1011

abitmore opened this issue Jun 2, 2018 · 10 comments
Assignees
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2h Accepted Status indicating the solution passed final review, and is ready for implementation 3b Feature Classification indicating the addition of novel functionality to the design 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 UX Impact flag identifying the User Interface (UX) cli

Comments

@abitmore
Copy link
Member

abitmore commented Jun 2, 2018

User Story
As a user I want to generate public/private key pairs without connecting to a node.

I think an easy approach is to add an option to cli_wallet, just like --version.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added the cli label Jun 2, 2018
@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2b Gathering Requirements Status indicating currently refining User Stories and defining Requirements 3b Feature Classification indicating the addition of novel functionality to the design 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 UX Impact flag identifying the User Interface (UX) labels Jun 2, 2018
@ryanRfox
Copy link
Contributor

ryanRfox commented Jun 2, 2018

Agreed. I often use the suggest_brain_key API of the cli_wallet to generate a new signing key pair. It would be helpful to call a command line app with this parameter to achieve the same result on an offline workstation.

@windycrypto
Copy link
Member

I'm just working on cli_wallet related stuff these days, may I take this issue? @ryanRfox

@ryanRfox
Copy link
Contributor

ryanRfox commented Jun 8, 2018

Yes, thank you @cifer-lee for claiming this Issue. I will move it to the Community Claims board for your development.

@ryanRfox ryanRfox added 2h Accepted Status indicating the solution passed final review, and is ready for implementation 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added and removed 2b Gathering Requirements Status indicating currently refining User Stories and defining Requirements labels Jun 11, 2018
@jmjatlanta
Copy link
Contributor

PR #1039 handled the code portion. Documentation of this new feature still needs to be completed.

@windycrypto
Copy link
Member

windycrypto commented Jun 18, 2018

Sorry i found nowhere to add document for command line option, not the description at option line? https://github.com/cifer-lee/bitshares-core/blob/4a2f333444b5d9a0cd13c78a16393594e9db1e6d/programs/cli_wallet/main.cpp#L89

Or did you mean the docs/ submodule?

@jmjatlanta
Copy link
Contributor

Very good question. Perhaps @ryanRfox can help. Ryan, where are the cli_wallet command line switches documented?

@ryanRfox
Copy link
Contributor

Sorry guys I'm not familiar enough to provide a definitive answer to where all it should documented at this time.

At minimum, when calling cli_wallet --help and returning the helpful note already placed within main.cpp. Thank you.

@cedar-book May I request you guide us to a good location(s) within the new developer documentation to note this new feature?

@cedar-book
Copy link

cedar-book commented Jun 19, 2018

@ryanRfox, I was just thinking about this (this kind of situation). As our starting point, I created a folder named documented_issues in a knowledge_base folder. How about we add the information in the folder? Because, probably, most time, like this moment we remember more what we had done and which information want to leave as the documentation.
And added am example page file for this. https://github.com/bitshares/dev.bitshares.works/blob/master/core/kowledge_base/documented_issues Let me know how you think.

@ryanRfox
Copy link
Contributor

ryanRfox commented Jul 9, 2018

fixed by #1039

@cedar-book
Copy link

cedar-book commented Jul 10, 2018

Right now, (I do not want to forget, neither. ) Created new section to collect these Documented issues information. For this issue, https://github.com/bitshares/dev.bitshares.works/blob/master/core/kowledge_base/documented_issues/1011_add_cli_startup.md

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2h Accepted Status indicating the solution passed final review, and is ready for implementation 3b Feature Classification indicating the addition of novel functionality to the design 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 UX Impact flag identifying the User Interface (UX) cli
Projects
None yet
Development

No branches or pull requests

5 participants