Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor get_account_limit_orders API account name support #1164

Closed
abitmore opened this issue Jul 21, 2018 · 4 comments
Closed

Refactor get_account_limit_orders API account name support #1164

abitmore opened this issue Jul 21, 2018 · 4 comments
Assignees
@oxarbitrage
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 API Impact flag identifying the application programing interface (API) api feature
Milestone
201808 - Non-Cons...

Comments

@abitmore
Copy link
Member

abitmore commented Jul 21, 2018 •
edited
Loading

When developing #989, get_account_limit_orders API was developing in parallel (#849), therefore it doesn't support account name as a parameter. We need to add the support. ** therefore it's implemented with old methods, we can refactor it.
@abitmore abitmore added api feature 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 API Impact flag identifying the application programing interface (API) labels Jul 21, 2018
@oxarbitrage
Copy link
Member

ill take care of this.

@oxarbitrage oxarbitrage self-assigned this Jul 21, 2018
@oxarbitrage oxarbitrage mentioned this issue Jul 21, 2018
Merged
@oxarbitrage
Copy link
Member

it turned out that get_account_limit_orders had support for account_name_or_id but by adding the same code we moved to a function in #989

this is fixed in #1168

@abitmore abitmore changed the title get_account_limit_orders API does not support account name Refactor get_account_limit_orders API account name support Jul 22, 2018
@abitmore
Copy link
Member Author

My bad. I thought it didn't support account name. Good to refactor though. OP updated. Thanks.

@abitmore
Copy link
Member Author

Merged #1168. Closing.

@abitmore abitmore mentioned this issue Aug 4, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@oxarbitrage oxarbitrage

Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 API Impact flag identifying the application programing interface (API) api feature
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

No branches or pull requests
2 participants
@abitmore @oxarbitrage