Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

API calls that omit limit should not fail #2619

Closed
2 of 17 tasks
abitmore opened this issue Aug 6, 2022 · 1 comment · Fixed by #2622
Closed
2 of 17 tasks

API calls that omit limit should not fail #2619

abitmore opened this issue Aug 6, 2022 · 1 comment · Fixed by #2622

Comments

@abitmore
Copy link
Member

abitmore commented Aug 6, 2022

Bug Description

For APIs with an optional limit, If the node operator configured a smaller limit, the API call should not fail if the client does not specify a limit.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Host Environment
Please provide details about the host environment. Much of this information can be found running: witness_node --version.

  • Host OS: [e.g. Ubuntu 18.04 LTS]
  • Host Physical RAM [e.g. 4GB]
  • BitShares Version: [e.g. 2.0.180425]
  • OpenSSL Version: [e.g. 1.1.0g]
  • Boost Version: [e.g. 1.65.1]

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Aug 6, 2022
@abitmore abitmore changed the title API calls that omits limit should not fail API calls that omit limit should not fail Aug 6, 2022
@abitmore abitmore linked a pull request Aug 6, 2022 that will close this issue
@abitmore
Copy link
Member Author

abitmore commented Aug 7, 2022

Fixed by #2622.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant