Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Accept a list of node_basenames for the DNSPoll strategy #191

Open
Qqwy opened this issue Mar 29, 2023 · 1 comment
Open

Accept a list of node_basenames for the DNSPoll strategy #191

Qqwy opened this issue Mar 29, 2023 · 1 comment
Labels

Comments

@Qqwy
Copy link

Qqwy commented Mar 29, 2023

I would like to give different basenames to the various machines in my (cross-region) cluster, to make it more obvious which node(s) are running in which region.

This will however not work with the DNSPoll strategy because it expects a single node_basename to be configured.

I think it could easily be adapted to support multiple node_basenames, by allowing the node_basename: field to accept a list of binaries (as well as as single binary as it does now).

@bitwalker
Copy link
Owner

That's probably fine, if you'd like to put together a PR for that change. The only problem I can see is that you'll need to attempt connecting to each name in the list for every IP returned by the DNS query until you successfully connect. That's probably not a big deal, but something to keep in mind when implementing the change.

@bitwalker bitwalker changed the title Feature request: Accept a list of node_basenames for the DNSPoll strategy Accept a list of node_basenames for the DNSPoll strategy Jun 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants