Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow template literals #162

Merged
merged 1 commit into from
Mar 5, 2023
Merged

feat: allow template literals #162

merged 1 commit into from
Mar 5, 2023

Conversation

simenandre
Copy link
Member

@simenandre simenandre commented Dec 28, 2022

Reasoning behind my change here is mainly jest snapshots. In most projects I work on, there are inline snapshots.

Which typically looks like this:

`"hello world"`

I feel we should allow for this.

Would love to hear feedback!

Reasoning behind my change here is mainly jest snapshots. In most projects I work on, there are inline snapshots (which typically looks like this: `"hello world"`). I feel we should allow for this.

Would love to hear feedback!
@simenandre simenandre requested review from braaar and moripen December 28, 2022 20:15
@braaar
Copy link
Member

braaar commented Jan 3, 2023

Doesn't this allow straight up using backticks?

const myString = `hello`

@simenandre
Copy link
Member Author

Doesn't this allow straight up using backticks?

const myString = `hello`

Not sure, let's check that before landing this. Also make sure that we only allow this in test files?

@simenandre
Copy link
Member Author

Doesn't this allow straight up using backticks?

const myString = `hello`

Not sure, let's check that before landing this. Also make sure that we only allow this in test files?

It is already only allowed in test files.

@simenandre
Copy link
Member Author

Doesn't this allow straight up using backticks?

const myString = `hello`

Not sure, let's check that before landing this. Also make sure that we only allow this in test files?

I checked this, and it does. However, I think it's fine for test files.

@braaar
Copy link
Member

braaar commented Feb 13, 2023

Doesn't this allow straight up using backticks?

const myString = `hello`

Not sure, let's check that before landing this. Also make sure that we only allow this in test files?

I checked this, and it does. However, I think it's fine for test files.

I agree. As long as it only applies to test files this is fine.

@simenandre simenandre merged commit 9f20d94 into main Mar 5, 2023
@simenandre simenandre deleted the allow-template-literals branch March 5, 2023 11:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants