HTTPRoute with RequestRedirect results in invalid spec

[lehmanju]

Details

What steps did you take and what happened:

Used following snippet:

route:
  main:
    parentRefs:
      - name: paperless-web
        namespace: paperless
        sectionName: https
    hostnames:
      - paperless.lan
    rules:
      - backendRefs:
          - kind: Service
            port: 80
            name: app
  redirect:
    parentRefs:
      - name: paperless-web
        namespace: paperless
        sectionName: http
    hostnames:
      - paperless.lan
    rules:
      - filters:
        - type: RequestRedirect
          requestRedirect:
            scheme: https
            statusCode: 301

This results in

# Source: app-template/templates/common.yaml
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: HTTPRoute
metadata:
  name: paperless-redirect
  labels:
    app.kubernetes.io/instance: paperless
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: paperless
    helm.sh/chart: app-template-3.7.2
  namespace: default
spec:
  parentRefs:
    - group: gateway.networking.k8s.io
      kind: Gateway
      name: paperless-web
      namespace: paperless
      sectionName: "http"
  hostnames:
    - "paperless.lan"
  rules:
  - backendRefs:
    filters:
      - requestRedirect:
          scheme: https
          statusCode: 301
        type: RequestRedirect

where backendRefs is empty and thus rejected because its value is 'null'.

What did you expect to happen:

backendRefs should be missing if not set

[larivierec]

This was done awhile back: 807dc71#diff-0b71571fdca8114ef5b6af19537d8ac82dcfbbd9ebcad4372ca1411e58c50180R77-R79

backendRefs should not be set as you can't use both here
test ref: test

i'd have to investigate

[lehmanju]

Yeah, it's impossible to use backendRefs and requestReditect simultaneously in the helm template but unfortunately the generated resource is not accepted by the cluster.

[lehmanju]

I think this is the culprit: https://github.com/bjw-s/helm-charts/blob/main/charts%2Flibrary%2Fcommon%2Ftemplates%2Fclasses%2F_route.tpl#L62

[larivierec]

Yes, you are right. It passes validation and then renders the route class.

We have to figure out a way to remove that when rules contain a request redirect filter.