Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exception when version is not specified in requirements.txt #95

Open
zerthimon opened this issue Mar 31, 2016 · 1 comment
Open

Exception when version is not specified in requirements.txt #95

zerthimon opened this issue Mar 31, 2016 · 1 comment

Comments

@zerthimon
Copy link

It would be nice if devpi-builder could install the latest version of requred package, when no version is specified for it ...

Traceback (most recent call last):
  File "/usr/local/bin/devpi-builder", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/devpi_builder/cli.py", line 105, in main
    packages = requirements.read(args.requirements)
  File "/usr/local/lib/python2.7/dist-packages/devpi_builder/requirements.py", line 41, in read
    _extract_project_version(requirement) for requirement in pkg_resources.parse_requirements(input_file)
  File "/usr/local/lib/python2.7/dist-packages/devpi_builder/requirements.py", line 27, in _extract_project_version
    raise ValueError('Version specification is missing for "{}".'.format(requirement))
ValueError: Version specification is missing for "websocket-client".
@theMarix
Copy link
Contributor

theMarix commented Apr 8, 2016

This is an interesting suggestion. I have actually had this use-case myself before. But it vanished because we now pip-compile all requirements used in our tests.

The tricky part about adding this feature is that I there was a reason why it currently is not allowed. We want to make sure that we don't accidentally build a wrong version. E.g. when automatically building all packages that passed a defined clearance process. So it is essential for use to retain the old behaviour.

If it is possible to get both behaviours – enabling the user to select the desired one – without adding too much complexity to the code base that would be great, though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants