From 5a1746b2d3a80ca7484669b3065f34aeb1ac76ee Mon Sep 17 00:00:00 2001 From: Steven Schoen Date: Thu, 11 Jan 2024 14:28:13 -0400 Subject: [PATCH] Fix doc mistake in ControllerChangeHandler (#691) --- .../bluelinelabs/conductor/ControllerChangeHandler.kt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/conductor/src/main/java/com/bluelinelabs/conductor/ControllerChangeHandler.kt b/conductor/src/main/java/com/bluelinelabs/conductor/ControllerChangeHandler.kt index 61ba094d..5ab4654f 100644 --- a/conductor/src/main/java/com/bluelinelabs/conductor/ControllerChangeHandler.kt +++ b/conductor/src/main/java/com/bluelinelabs/conductor/ControllerChangeHandler.kt @@ -29,15 +29,15 @@ abstract class ControllerChangeHandler { * If this is true: * - This handler's implementation of [performChange] should remove `from` from `container` * before calling `changeListener.onChangeCompleted()` - * - When a controller is pushed, the previous controller will stay attached and its view will remain created - * - When a view is recreated (e.g. after a configuration change), any controllers underneath a transaction - * using this handler will have their view recreated and attached, even though they're not the top-most - * controller + * - When a controller is pushed, the previous controller will be detached and its view will be destroyed * * If this is false: * - This handler's implementation of [performChange] should only remove `from` from `container` * when `isPush` is false - * - When a controller is pushed, the previous controller will be detached and its view will be destroyed + * - When a controller is pushed, the previous controller will stay attached and its view will remain created + * - When a view is recreated (e.g. after a configuration change), any controllers underneath a transaction + * using this handler will have their view recreated and attached, even though they're not the top-most + * controller * * If a controller pushed onto the backstack will completely cover the previous controller, * using a change handler with [removesFromViewOnPush] true should result in no visual interruption