-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add warning message when exporting svg from workflow #18
Comments
@cjsha this is a good idea. I am wondering whether we should go further and actually fail the call with an error, since for such purposes the resulting export will most likely never be quite useful. That way CI systems could more easily signal a failure in their pipelines. |
Should it be an option to elevate from warning to error? I can imagine a situation in which you want to export an uncompilable workflow to discuss specific reasons why a workflow might not compile and how Bonsai behaves in those situations |
Potentially semi-related: bonsai-rx/bonsai#2096 Since we're strongly pushing people towards GitHub Actions for publishing documentation, it would be nice if either:
Either of these will result in the errors ending up in the workflow run summary. Which is ideal since the docfx is pretty noisy. |
When exporting SVGs, I think it could be helpful to have a warning message if a workflow does not compile or the environment doesn't contain all the necessary packages to run the workflow (which creates hatched nodes in the exported SVG).
The text was updated successfully, but these errors were encountered: