virtual-host addressing style not working with custom tls verification #2939
Labels
bug
This issue is a confirmed bug.
endpoints
needs-review
This issue or pull request needs review from a core team member.
p2
This is a standard priority issue
s3
Describe the bug
Subdomains are only allowed to use virtual-host addressing with http endpoints.
https://github.com/boto/botocore/blob/2091c2629f320c2dd16c9e29a0690d493375c8a7/botocore/data/s3/2006-03-01/endpoint-rule-set-1.json#L5314-L5337
https://github.com/boto/botocore/blob/2091c2629f320c2dd16c9e29a0690d493375c8a7/botocore/data/s3/2006-03-01/endpoint-rule-set-1.json#L2325-L2335
Expected Behavior
Should allow addressing subdomain buckets via virtual-host addressing style so one can properly filter egress.
Current Behavior
HTTPS endpoints are forced to use path-style addressing with subdomain buckets.
Reproduction Steps
See above.
Possible Solution
Allow virtual-host style addressing with disabled/manual TLS verification.
Possibly via an additional parameter.
Our workaround sets urllib3's assert_hostname to
s3.amazonaws.com
to still perform TLS verification. So maybe that would be a clearer parameter.Could possibly be internalised to botocore as a boolean option even.
Additional Information/Context
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
SDK version used
botocore==1.29.105
Environment details (OS name and version, etc.)
na
The text was updated successfully, but these errors were encountered: