Change exception text to be more readable

[shayfisher]

Describe the feature

After reading this article - https://docs.aws.amazon.com/appstream2/latest/developerguide/access-api-cli-through-interface-vpc-endpoint.html
They have the following example:
appstream2client = boto3.client('appstream',region_name='<aws-region>',endpoint_url='<vpc-endpoint-id>.api.appstream.<aws-region>.vpce.amazonaws.com'
If endpoint url is given for the boto3 appstream client without a schema (HTTPS/HTTP) the following exception is raised (ValueError) -

botocore/botocore/endpoint.py

Line 402 in a3c3628

raise ValueError("Invalid endpoint: %s" % endpoint_url)

which doesn't help the developer understand what should he fix

Use Case

I'm trying to use appstream API via boto3 from Lambda

Proposed Solution

I would suggest adding schema to the error message so it would be clear what is the desired fix -
e.g - raise ValueError("Invalid endpoint: HTTPS/HTTP://%s" % endpoint_url) or something like that

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

SDK version used

1.29.152

Environment details (OS name and version, etc.)

Windows/Linux

[tim-finnigan]

Hi @shayfisher thanks for the feature request. Here is the is_valid_endpoint_url function code for reference, and here is where is_valid_ipv6_endpoint_url is defined.

Because there are several conditions that could result in the Invalid endpoint... message, there are some nuances to consider for what the error message should say. I think more discussion is needed to determine what improvements there could be to the error message depending on each condition.

Also in the meantime you could also consider get more detailed logs when debugging by adding boto3.set_stream_logger('') to your script.