Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Get Film Details Endpoint fails on films with casts #179

Closed
hikasap opened this issue May 15, 2024 · 2 comments · Fixed by #181
Closed

Get Film Details Endpoint fails on films with casts #179

hikasap opened this issue May 15, 2024 · 2 comments · Fixed by #181
Assignees
Labels
backend bug Something isn't working priority: high Very urgent issue workload: 1 issues that are requiring low effort

Comments

@hikasap
Copy link
Contributor

hikasap commented May 15, 2024

I have detected that our endpoint for get film details fails when asked with a film with cast members. To reproduce the error, one can run the following request
curl -X 'POST' \ 'http://207.154.242.6:8020/get-film-details/' \ -H 'accept: */*' \ -H 'Content-Type: application/json' \ -H 'X-CSRFToken: F607pTp2lWmP4YiD49TKv7fOn3pqddqvHEMiu12SnKMwzmE3gnr8VSEsMxOO8keT' \ -d '{ "entity_id": "Q21500755" }'

Reviewer

@m-erkam

@hikasap hikasap added bug Something isn't working backend labels May 15, 2024
@hikasap hikasap self-assigned this May 15, 2024
@hikasap hikasap changed the title Get Film Details Endpoint fails on Films with casts Get Film Details Endpoint fails on films with casts May 15, 2024
@hikasap hikasap added workload: 1 issues that are requiring low effort priority: high Very urgent issue labels May 15, 2024
@hikasap
Copy link
Contributor Author

hikasap commented May 16, 2024

I have realized that we are hitting rate limits of wikidata API when we try to fetch so many cast member labels on film details call thus it fails. Will try to find a solution to that.

@hikasap hikasap linked a pull request May 16, 2024 that will close this issue
@hikasap
Copy link
Contributor Author

hikasap commented May 16, 2024

Merged and closed.

@hikasap hikasap closed this as completed May 16, 2024
@mahmutbugramert mahmutbugramert added this to the Final Deployment milestone May 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backend bug Something isn't working priority: high Very urgent issue workload: 1 issues that are requiring low effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants