Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[CLOSED] Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts #1123

Open
core-ai-bot opened this issue Aug 29, 2021 · 2 comments
Open

[CLOSED] Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts #1123

core-ai-bot opened this issue Aug 29, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by RaymondLim
Saturday Jun 23, 2012 at 17:16 GMT
Originally opened as adobe/brackets#1134

Fix KeyBindingManager unit test failed issue #1132

RaymondLim included the following code: https://github.com/adobe/brackets/pull/1134/commits
@core-ai-bot
Copy link
Member Author

Comment by gruehle
Saturday Jun 23, 2012 at 20:14 GMT

This fixes all of the unit test on windows and most of the tests on the mac. I'm still seeing one error in the Menus tests on the mac.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Sunday Jun 24, 2012 at 00:43 GMT

Tests all pass now. Could you file a bug to fix the menu tests? Ideally we would check for mac and windows bindings for newly-created menu items.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot