[CLOSED] Adds support for menus sections, fixes #1210

[core-ai-bot]

Issue by tvoliter
Friday Jul 13, 2012 at 01:34 GMT
Originally opened as adobe/brackets#1247

---

addMenuItem() now supports a MenuSection constant for the relativeID parameter. The new menu is then supported at the end or beginning of the section, where the section is denoted by dividers or the beginning/end of a menu.

fixes #1210

---

tvoliter included the following code: https://github.com/adobe/brackets/pull/1247/commits

[core-ai-bot]

Comment by tvoliter
Monday Jul 16, 2012 at 22:58 GMT

---

Hi Randy, I followed your suggestion of using new position constants which made the code simpler too. I've pushed my fixes for the review

[core-ai-bot]

Comment by redmunds
Tuesday Jul 17, 2012 at 03:18 GMT

---

2 minor comments, then it's ready to merge.

[core-ai-bot]

Comment by tvoliter
Tuesday Jul 17, 2012 at 04:41 GMT

---

Thanks Randy. Fixes pushed.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com]
Sent: Monday, July 16, 2012 8:18 PM
To: Ty Voliter
Subject: Re: [brackets] Adds support for menus sections, fixes #1210 (#1247)

2 minor comments, then it's ready to merge.

---

Reply to this email directly or view it on GitHub:
adobe/brackets#1247 (comment)