Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CLOSED] Fixed apostrophes. #6647

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] Fixed apostrophes. #6647

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by FezVrasta
Tuesday Apr 01, 2014 at 07:36 GMT
Originally opened as adobe/brackets#7369



FezVrasta included the following code: https://github.com/adobe/brackets/pull/7369/commits

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Tuesday Apr 01, 2014 at 10:27 GMT


FezVrasta has NOT submitted the contributor license agreement.
See http://dev.brackets.io/brackets-contributor-license-agreement.html

Did you sign it?

@core-ai-bot
Copy link
Member Author

Comment by FezVrasta
Tuesday Apr 01, 2014 at 11:09 GMT


Didn't know about that, just submitted it.

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Tuesday Apr 01, 2014 at 11:32 GMT


You need to make another push to trigger Travis again or re-commit this change like this:

git reset --soft HEAD~1
git commit -m "Fixed apostrophes"
git push -f

... nevermind - I found a restart button in Travis :-)

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Tuesday Apr 01, 2014 at 11:39 GMT


Ok, Travis passes now, thanks for signing the agreement.

I'll leave to someone else to merge this since I don't speak Italian or French. For info we had a discussion about apostrophes vs single quotes here brackets-userland/brackets-git#329

@core-ai-bot
Copy link
Member Author

Comment by FezVrasta
Tuesday Apr 01, 2014 at 12:01 GMT


Done, thanks.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Apr 01, 2014 at 16:24 GMT


@zaggino - for something like this I think it's ok to just merge if you can verify that none of the text really changed. I'll go ahead and push the button. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant