[CLOSED] fix as suggested in #7333

[core-ai-bot]

Issue by zaggino
Tuesday Apr 22, 2014 at 03:31 GMT
Originally opened as adobe/brackets#7599

---

---

zaggino included the following code: https://github.com/adobe/brackets/pull/7599/commits

[core-ai-bot]

Comment by zaggino
Tuesday Apr 22, 2014 at 03:31 GMT

---

cc@RaymondLim@hpoom

[core-ai-bot]

Comment by MarcelGerber
Tuesday Apr 22, 2014 at 14:27 GMT

---

Well, I'm not sure whether root should be changed to English (US) - it's used for other English speaking countries (Australia, Canada) as well (and of course it's the main fallback).

[core-ai-bot]

Comment by hpoom
Tuesday Apr 22, 2014 at 21:13 GMT

---

@zaggino Like the fix, thanks. Should have coded it myself, next time.

@SAPlayer I think English (US) is OK, I would even go so far to suggest LOCALE_EN should be LOCALE_EN_US. When you see how other software and organisations deal with this, calling the it en-us is standard. I accept that other countries speak this variation of English, but most other software still calls it en-us.

See Firefox as an example:
http://www.mozilla.org/en-US/firefox/all/
On that pages there is English (British), English (South African) and English (US). In the configs it is en-GB, en-ZA and en-US

Chrome is similar, they call it English (United States).

I think we are best to change Brackets to be inline with the conventions set by other software and to adhere as closely as possible to the ISO standards.

[core-ai-bot]

Comment by zaggino
Tuesday Apr 22, 2014 at 22:11 GMT

---

Australia & Canada (and a lot of former colonies) use British English so I don't think we need to add more than US & UK. Only question for me is if it should be US & UK or United States & British or whatever should be displayed for the end user. It seems every software uses different terms here (British in Firefox vs United Kingdom in Chrome)

[core-ai-bot]

Comment by RaymondLim
Tuesday Apr 22, 2014 at 22:34 GMT

---

I think US & UK are perfectly fine.@SAPlayer Showing English (US) for root is better when we have English (UK) showing in the list.

[core-ai-bot]

Comment by RaymondLim
Wednesday Apr 23, 2014 at 04:33 GMT

---

LGTM. Merging.