Skip to content

[docs] clarification on genDir option #49

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
GiuseppePiscopo opened this issue Jan 8, 2017 · 1 comment
Closed

[docs] clarification on genDir option #49

GiuseppePiscopo opened this issue Jan 8, 2017 · 1 comment

Comments

@GiuseppePiscopo
Copy link

In options doc page it is mentioned that if you set the angularCompilerOptions.genDir option in tsconfig.json, then the genDir option in loader

[...] needs to be set to the relative path to your application directory.

Just expanding on example provided in docs, the structure (after an AOT build) should look like:

|--+ compiled\
   `--+ src\
      `--- app\

|--+ src\
   `--- app\

|-- tsconfig.json

Is it correct that the option value in loader should be exactly the same as in tsconfig.json? If that's true, would you be ok with a PR adding such clarification to the doc?

If that's not correct, could you please explain a bit more the rationale? Is application directory the path where package.json and others are located? Or the path where source code entry point is located? Or else?

Thanks a lot

@brandonroberts
Copy link
Owner

@GiuseppePiscopo You're correct. I recently merged in some changes so the two genDir values could match but didn't update the docs yet. I would definitely be ok with a PR clarifying that.

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants