Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Block autoplay by default but allow the user to change it #1047

Closed
bbondy opened this issue Sep 9, 2018 · 3 comments · Fixed by brave/brave-core#455
Closed

Block autoplay by default but allow the user to change it #1047

bbondy opened this issue Sep 9, 2018 · 3 comments · Fixed by brave/brave-core#455

Comments

@bbondy
Copy link
Member

bbondy commented Sep 9, 2018

I think the popup window is too much on each site and can get in the way of browsing. I find it almost as annoying as the autoplay itself. I think just the URL bar thing like widevine is enough.

Putting in 1.x backlog, but I'd love a patch.

@bbondy bbondy added this to the 1.x Backlog milestone Sep 9, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Autoplay without sound is on by default in chrome/firefox/safari. We should match that behavior for autoplay without sound.

Example: https://www.simplehuman.com and https://www.tesla.com/models (scroll to mid-page car driving video - range section)

@bbondy
Copy link
Member Author

bbondy commented Sep 10, 2018

We'll do the sound only task in the context of #1088

@btlechowski
Copy link

btlechowski commented Sep 27, 2018

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7

image

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

# for free to join this conversation on GitHub. Already have an account? # to comment