BAP cutoff date isn't correctly detected

[LaurenWags]

Description

Found while testing #13701 / brave/brave-core#7698

Unable to claim staging UGP grant when in Japan region.

Steps to Reproduce

1. Clean profile on Nightly w/ region = Japan and staging env
2. Click on Rewards icon and enable Rewards
3. No UGP grant.

Actual result:

No UGP grant is offered. See the below in logs:

[7846:775:0210/113532.139689:VERBOSE1:promotion.cc(113)] Fetch promotions disabled for BAP migration

Expected result:

Since date has not been met, UGP grant should be available

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.22.16 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision	2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS	macOS Version 10.15.7 (Build 19H512)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @zenparsing @Miyayes

[kjozwiak]

Going to need to recheck this quickly we uplift it into 1.21.x 👍 Removing QA Pass-macOS so it doesn't get missed.

[kjozwiak]

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Region: Japan & Language: English

Example	Example	Example

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/5d1ab283-6fbc-4e68-bfad-8b2a472b8088
> Result: Success
> HTTP Code: 200

Region: Japan & Language: Japan

Example	Example	Example

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/8fe2f8e9-89ff-4b2c-b71d-08c3ec7dfc6b
> Result: Success
> HTTP Code: 200

---

Verified passed with

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 10.15.7 (Build 19H524)

Region: Japan & Language: English

Example	Example	Example	Example

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/2321f82d-e47a-41e8-b73a-653ea8006b7e
> Result: Success
> HTTP Code: 202

Region: Japan & Language: Japan

Example	Example	Example	Example

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/fc62b06b-1495-4ed6-b2b0-3ad725c7e2a5
> Result: Success
> HTTP Code: 202

---

Verification passed on

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	Ubuntu 18.04 LTS

---------------|-----------------
|

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions/f05568e6-f4a1-4438-8e81-cc0490fd14f7/claims/e59a209c-309d-47d9-b176-28d283a1a0ac
> Result: Success
> HTTP Code: 202

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

• Verified able to claim grant for Locale US

   [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/c8a0d23e-0e5b-45f2-a554-546bb2172dd6
    > Result: Success
    > HTTP Code: 200

• Verified able to claim grant for Locale Japanese

[ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"2e61f61e-d4f4-400b-90d1-e3ab18c3b50a"}
2021-03-11 08:09:05.280 20957-20957/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Method: UrlMethod::GET
2021-03-11 08:09:05.543 20957-20957/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Result: Success
    > HTTP Code: 200

---

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

• Verified able to claim grant for Locale US

 2021-03-11 09:02:51.970 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9"}
2021-03-11 09:02:52.009 12229-12229/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Method: UrlMethod::GET
2021-03-11 09:02:52.296 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Result: Success
    > HTTP Code: 200

• Verified able to claim grant for Japanese Locale

2021-03-11 08:48:33.906 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"df77bc65-f5b2-47dd-9ab2-848ed02f2221"}
2021-03-11 08:48:33.932 6514-6514/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Method: UrlMethod::GET
2021-03-11 08:48:34.209 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Result: Success
    > HTTP Code: 200