Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve start and stop button behaviour for brave://ipfs #14115

Closed
spylogsster opened this issue Feb 11, 2021 · 2 comments · Fixed by brave/brave-core#7937
Closed

Improve start and stop button behaviour for brave://ipfs #14115

spylogsster opened this issue Feb 11, 2021 · 2 comments · Fixed by brave/brave-core#7937
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Milestone
1.22.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Feb 11, 2021 •
edited
Loading

Start and stop button should only show when it is applicable

image
@spylogsster spylogsster added priority/P4 Planned work. We expect to get to it "soon". feature/web3/ipfs OS/Desktop labels Feb 11, 2021
@spylogsster spylogsster self-assigned this Feb 11, 2021
@spylogsster spylogsster changed the title Start and stop button should only show when it is applicable Improve start and stop button behaviour for brave://ipfs Feb 11, 2021
This was referenced Feb 11, 2021
Merged
Closed
@spylogsster spylogsster added this to the 1.22.x - Nightly milestone Feb 20, 2021
@stephendonner
Copy link

Before testing, make sure #14300 is fixed.

@stephendonner
Copy link

Verified FIXED on beta using

Brave 1.22.49 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)

Verified:

  • clicking Start starts the node/daemon, starts populating the respective stats and paths, and Restart and My Node buttons appear
  • after clicking Stop, button text changes to Start and there are no Stop and Restart buttons
  • clicking Restart clear stats, and paths, and Stop, Restart, and My Node buttons appear
  • clicking My Node goes to a URL like so: http://127.0.0.1:45004/ipfs/bafybeianwe4vy7sprht5sm3hshvxjeqhwcmvbzq73u55sdhqngmohkjgs4/#/ with a fuller IPFS UI status page (not covered in the screencast, but tested)

ipfs-start-stop

@LaurenWags LaurenWags mentioned this issue Mar 22, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Start and stop button should only show when it is applicable brave/brave-core
2 participants
@stephendonner @spylogsster