(Ledger client) Capture more details when linking anonymous wallet to custodian #15257
Labels
feature/rewards
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
Description
Overview of process
Verify Wallet
button on brave://rewardsProblem
The problem is that sometimes folks are getting stuck and need to reach out to @brave/rewards-support to provide more information to help get unstuck. This is a bad experience and requires a lot of manual intervention
What happens in the code
When a person w/ Brave Rewards enabled connects their wallet to Uphold for the first time, a few things will happen:
Problems / what could be better
We throw away most of the response in steps 2 and 3 above (claim / transfer tokens). This could be extremely useful in debugging and could be logged to brave://rewards-internals or saved to profile
response.status_code
). We completely ignore the other fields, likeresponse.body
which have more information about the call (click here for source)drain_id
. We should be able to poll thisdrain_id
for a text status (ex: pending, in progress, delayed, complete). iOS recently implemented a feature like this for QR code transfer to desktop. You can see where the callback for transfer tokens resolves, it passes indrain_id
which can then be logged to brave://rewards-internals or saved to profile (click here for source)Besides the support cost and impact to customers... code-maintenance-wise, the client code can be a bit hard to follow (lots of callbacks!). This would be a great example to clean up
The text was updated successfully, but these errors were encountered: