-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replaced temp strings with final strings #1858
Closed
bradleyrichter opened this issue
Oct 26, 2018
· 4 comments
· Fixed by brave/brave-core#743 or brave/brave-core#808
Closed
Replaced temp strings with final strings #1858
bradleyrichter opened this issue
Oct 26, 2018
· 4 comments
· Fixed by brave/brave-core#743 or brave/brave-core#808
Milestone
Comments
@bradleyrichter are we still going with |
@srirambv we need to edit this Could you make a pr for it? |
@bradleyrichter brave/brave-core#808 created and ready for review |
Verification Passed on
Verified passed with
Verified passed with
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Test Cases
Hmmm, not quite...
* enable rewards and fail the CAPTCHA, error message should appear asHmmm… not quite
instead ofHmmm…not quite.
Going to ping @evq to see if there's a way we can test the remaining string changes. It requires the grant server to be put into certain scenarios. - @kjozwiak
Original Issue
issue for PR: brave/brave-core#743
The text was updated successfully, but these errors were encountered: