Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replaced temp strings with final strings #1858

Closed
bradleyrichter opened this issue Oct 26, 2018 · 4 comments · Fixed by brave/brave-core#743 or brave/brave-core#808
Closed

Replaced temp strings with final strings #1858

bradleyrichter opened this issue Oct 26, 2018 · 4 comments · Fixed by brave/brave-core#743 or brave/brave-core#808

Comments

@bradleyrichter
Copy link

bradleyrichter commented Oct 26, 2018

Test Cases

  • Enable rewards and fail CAPTCHA should show error message as Hmmm, not quite...

* enable rewards and fail the CAPTCHA, error message should appear as Hmmm… not quite instead of Hmmm…not quite.

Going to ping @evq to see if there's a way we can test the remaining string changes. It requires the grant server to be put into certain scenarios. - @kjozwiak

Original Issue

issue for PR: brave/brave-core#743

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2018

@bradleyrichter are we still going with Hmmm... not quite. ? or are we changing it to Hmmm, not quite...?

@bradleyrichter
Copy link
Author

@srirambv we need to edit this

Could you make a pr for it?

@srirambv srirambv mentioned this issue Nov 5, 2018
18 tasks
@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2018

@bradleyrichter brave/brave-core#808 created and ready for review

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 7, 2018

Verification Passed on

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified test case comment

image

Verified passed with

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

screen shot 2018-11-07 at 9 44 09 am

Verified passed with

Brave 0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

image

# for free to join this conversation on GitHub. Already have an account? # to comment